fix: add explicit dependency on rigetti-pyo3's "time" feature #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rigetti/rigetti-pyo3#45 (and rigetti/rigetti-pyo3#46), I moved all references to the Python time types under the "time" feature. This was a bugfix, but I didn't realize it was also a breaking change – any library that relied on the time types implicitly being available would break, just as this one did! This adds the missing feature dependency, and I've also upgraded rigetti/rigetti-pyo3#46 to be a breaking change. This commit also updates Cargo.lock to force the update to rigetti-pyo3, meaning that builds will fail without the substantive change.
|
BatmanAoD
approved these changes
Jun 14, 2024
Updating the other dependencies brings in new licenses (Unicode-3.0), which is probably fine but not something we need to figure out right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rigetti/rigetti-pyo3#45 (and rigetti/rigetti-pyo3#46), I moved all references to the Python time types under the "time" feature. This was a bugfix, but I didn't realize it was also a breaking change – any library that relied on the time types implicitly being available would break, just as this one did! This adds the missing feature dependency, and I've also upgraded rigetti/rigetti-pyo3#46 to be a breaking change.
This commit also updates Cargo.lock to force the update to rigetti-pyo3, meaning that builds will fail without the substantive change.
Closes #475.